Skip to content

Commit 76d265e

Browse files
authored
Merge pull request #39 from ExpediaGroup/tipike/go_server_crash
fix linting
2 parents d2284ef + efe3128 commit 76d265e

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

go/internal/feast/transformation/transformation.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,13 +122,14 @@ func CallTransformations(
122122
cdata.ExportArrowRecordBatch(inputRecord, &inputArr, &inputSchema)
123123

124124
// Recover from a panic from FFI so the server doesn't crash
125+
var err error
126+
ret := callback(featureView.Base.Name, inputArrPtr, inputSchemaPtr, outArrPtr, outSchemaPtr, fullFeatureNames)
125127
defer func() {
126128
if e := recover(); e != nil {
127-
ret = nil
128-
nil = e.(Error)
129+
ret = -1
130+
err = e.(error)
129131
}
130132
}()
131-
ret := callback(featureView.Base.Name, inputArrPtr, inputSchemaPtr, outArrPtr, outSchemaPtr, fullFeatureNames)
132133

133134
if ret != numRows {
134135
return nil, errors.New("python transformation callback failed")

0 commit comments

Comments
 (0)