Skip to content

Commit 33b16ce

Browse files
authored
Merge pull request #28 from ExpediaGroup/debug_apply
fixc linting
2 parents d2e2071 + b7409d7 commit 33b16ce

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

sdk/python/feast/feature_store.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,8 @@ def apply(
821821
... )
822822
>>> fs.apply([driver_hourly_stats_view, driver]) # register entity and feature view
823823
"""
824-
print(f"Apply with: {objects}") #TODO: remove
824+
# TODO: remove
825+
print(f"Apply with: {objects}")
825826
# TODO: Add locking
826827
if not isinstance(objects, Iterable):
827828
objects = [objects]
@@ -992,12 +993,15 @@ def apply(
992993
tables_to_delete: List[FeatureView] = views_to_delete + sfvs_to_delete if not partial else [] # type: ignore
993994
tables_to_keep: List[FeatureView] = views_to_update + sfvs_to_update # type: ignore
994995

995-
print(f"""Update project={self.project},
996+
# TODO: remove
997+
print(
998+
f"""Update project={self.project},
996999
tables_to_delete={tables_to_delete},
9971000
tables_to_keep={tables_to_keep},
9981001
entities_to_delete={entities_to_delete if not partial else []},
9991002
entities_to_keep={entities_to_update},
1000-
partial={partial},""") #TODO: remove
1003+
partial={partial},"""
1004+
)
10011005
self._get_provider().update_infra(
10021006
project=self.project,
10031007
tables_to_delete=tables_to_delete,

sdk/python/feast/infra/passthrough_provider.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ def update_infra(
116116
):
117117
set_usage_attribute("provider", self.__class__.__name__)
118118

119-
print(f"Is online store={self.online_store}") #TODO: remove
119+
# TODO: remove
120+
print(f"Is online store={self.online_store}")
120121
# Call update only if there is an online store
121122
if self.online_store:
122123
self.online_store.update(

0 commit comments

Comments
 (0)