https://crash.pmmp.io/view/8184492

[Endermanbugzjfc]

https://crash.pmmp.io/view/8184492

[DuoIncure]

This crash is caused as the NPCSubcommand class adds "" around the {player} variable:

Quest/src/Endermanbugzjfc/Quest/commands/NPCSubcommand.php

Line 81 in 9785e87

"quest dialog \"{$quest->getCategory()}\" \"{player}\""

But SimpleNPC also adds "" around the {player} variable already:

https://github.com/brokiem/SimpleNPC/blob/0a2ec1ec5105b141196bde4847074a33324c19c9/src/brokiem/snpc/entity/CustomHuman.php#L109

Which means $args[1] inside DialogSubcommand is becoming PlayerName"" instead of just PlayerName. If you remove the "" from NPCSubcommand the crash no longer happens and the dialog should work as intended.

This is the same issue as #2 .

[Endermanbugzjfc]

This crash is caused as the NPCSubcommand class adds "" around the {player} variable:

Quest/src/Endermanbugzjfc/Quest/commands/NPCSubcommand.php

Line 81 in 9785e87

"quest dialog \"{$quest->getCategory()}\" \"{player}\""

But SimpleNPC also adds "" around the {player} variable already:

https://github.com/brokiem/SimpleNPC/blob/0a2ec1ec5105b141196bde4847074a33324c19c9/src/brokiem/snpc/entity/CustomHuman.php#L109

Which means $args[1] inside DialogSubcommand is becoming PlayerName"" instead of just PlayerName. If you remove the "" from NPCSubcommand the crash no longer happens and the dialog should work as intended.

This is the same issue as #2 .

Thank you.