Merge pull request #11781 from DestinyItemManager/lo-exotic-tuners

tuned stat fixes for exotics

Author: delphiactual

src/app/inventory/__snapshots__/d2-stores.test.ts.snap

@@ -9167,7 +9167,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 81,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Hunter Cloak",
     "Weapons": 25,
     "Weapons (Base)": 25,
@@ -10906,7 +10906,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Gauntlets",
     "Weapons": 0,
     "Weapons (Base)": 0,
@@ -11166,7 +11166,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Chest Armor",
     "Weapons": 0,
     "Weapons (Base)": 0,
@@ -11388,7 +11388,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Gauntlets",
     "Weapons": 30,
     "Weapons (Base)": 30,
@@ -11609,7 +11609,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Chest Armor",
     "Weapons": 25,
     "Weapons (Base)": 25,
@@ -12256,7 +12256,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Leg Armor",
     "Weapons": 30,
     "Weapons (Base)": 30,
@@ -12602,7 +12602,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Chest Armor",
     "Weapons": 0,
     "Weapons (Base)": 0,
@@ -12862,7 +12862,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Gauntlets",
     "Weapons": 0,
     "Weapons (Base)": 0,
@@ -13382,7 +13382,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Chest Armor",
     "Weapons": 20,
     "Weapons (Base)": 20,
@@ -13556,7 +13556,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Gauntlets",
     "Weapons": 20,
     "Weapons (Base)": 20,
@@ -13687,7 +13687,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Gauntlets",
     "Weapons": 0,
     "Weapons (Base)": 0,
@@ -13732,7 +13732,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Chest Armor",
     "Weapons": 0,
     "Weapons (Base)": 0,
@@ -14640,7 +14640,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Hunter Cloak",
     "Weapons": 30,
     "Weapons (Base)": 30,
@@ -14686,7 +14686,7 @@ exports[`process stores generates a correct armor CSV export 1`] = `
     "Tier": 5,
     "Total": 75,
     "Total (Base)": 75,
-    "Tuning Stat": "health",
+    "Tuning Stat": undefined,
     "Type": "Hunter Cloak",
     "Weapons": 20,
     "Weapons (Base)": 20,

src/app/loadout-builder/process/mappers.ts

@@ -110,7 +110,10 @@ export function mapDimItemToProcessItems({
   const tuningSocket = getArmor3TuningSocket(dimItem);
 
   // Make a version of the item for each possible tuning mod that could be applied.
-  if (autoStatMods && tuningSocket?.reusablePlugItems?.length) {
+  //
+  // exclude tuning mods for exotics since they have so many tuning options that it blows up the combinations.
+  //
+  if (autoStatMods && !isExotic && tuningSocket?.reusablePlugItems?.length) {
     const processItems: ProcessItem[] = [];
     const allPlugs = tuningSocket.plugSet?.plugs;
     // By default, we'll sacrifice the last ignored stat, or the last from among the lowest maximums

src/app/loadout/mod-assignment-utils.ts

@@ -383,7 +383,10 @@ export function fitMostMods({
   // stats), so if we assigned them in a different order than they were chosen
   // in the process loop, we might end up with different stats than the user
   // expected.
-  const tuningItems = items.filter((i) => getArmor3TuningStat(i) !== undefined);
+  //
+  // Exclude exotics since they blow up the combos since they have all the tuning sockets.
+  //
+  const tuningItems = items.filter((i) => !i.isExotic && getArmor3TuningStat(i) !== undefined);
   for (const tuningMod of tuningMods) {
     // Find the tuning stat hash, which is the stat that gets +5 when this mod
     // is applied. For "Balanced Tuning" this should be 0.

src/app/utils/item-utils.ts

@@ -406,10 +406,17 @@ export function getArmor3TuningStat(item: DimItem): StatHashes | undefined {
     return;
   }
 
+  let tunedStat: StatHashes | undefined;
   for (const { plugItemHash } of reusablePlugItems) {
-    if (plugItemHash in tuningModToTunedStathash) {
-      return tuningModToTunedStathash[plugItemHash];
+    const stat = tuningModToTunedStathash[plugItemHash];
+    if (stat !== undefined) {
+      if (tunedStat !== undefined && tunedStat !== stat) {
+        // Multiple different stat tuners available (e.g. exotics) --
+        // this item isn't locked to a single tuning stat.
+        return undefined;
+      }
+      tunedStat = stat;
     }
   }
-  return undefined;
+  return tunedStat;
 }