Skip to content

Commit 214fe79

Browse files
authored
Merge pull request #45 from phh235/fix/preact-effect-dependencies
Fix/preact effect dependencies
2 parents 5026c2c + 0ced953 commit 214fe79

28 files changed

Lines changed: 28 additions & 28 deletions

src/lib/Asciify/Asciify.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function useSyncExternalStore<T>(
1919
useEffect(() => {
2020
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2121
return unsubscribe;
22-
}, []);
22+
}, [subscribe, getSnapshot]);
2323
return value;
2424
}
2525

src/lib/Bend/Bend.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function useSyncExternalStore<T>(
1818
useEffect(() => {
1919
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2020
return unsubscribe;
21-
}, []);
21+
}, [subscribe, getSnapshot]);
2222
return value;
2323
}
2424

src/lib/Blaze/Blaze.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function useSyncExternalStore<T>(
1818
useEffect(() => {
1919
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2020
return unsubscribe;
21-
}, []);
21+
}, [subscribe, getSnapshot]);
2222
return value;
2323
}
2424

src/lib/Bubble/Bubble.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function useSyncExternalStore<T>(
1818
useEffect(() => {
1919
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2020
return unsubscribe;
21-
}, []);
21+
}, [subscribe, getSnapshot]);
2222
return value;
2323
}
2424

src/lib/Canvas/Canvas.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function useSyncExternalStore<T>(
1818
useEffect(() => {
1919
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2020
return unsubscribe;
21-
}, []);
21+
}, [subscribe, getSnapshot]);
2222
return value;
2323
}
2424

src/lib/Cloth/Cloth.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function useSyncExternalStore<T>(
2424
useEffect(() => {
2525
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2626
return unsubscribe;
27-
}, []);
27+
}, [subscribe, getSnapshot]);
2828
return value;
2929
}
3030

src/lib/Clouds/Clouds.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function useSyncExternalStore<T>(
1818
useEffect(() => {
1919
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2020
return unsubscribe;
21-
}, []);
21+
}, [subscribe, getSnapshot]);
2222
return value;
2323
}
2424

src/lib/DecryptReveal/DecryptReveal.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function useSyncExternalStore<T>(
1818
useEffect(() => {
1919
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2020
return unsubscribe;
21-
}, []);
21+
}, [subscribe, getSnapshot]);
2222
return value;
2323
}
2424

src/lib/Displacement/Displacement.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function useSyncExternalStore<T>(
1818
useEffect(() => {
1919
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2020
return unsubscribe;
21-
}, []);
21+
}, [subscribe, getSnapshot]);
2222
return value;
2323
}
2424

src/lib/Droplets/Droplets.preact.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function useSyncExternalStore<T>(
2424
useEffect(() => {
2525
const unsubscribe = subscribe(() => setValue(getSnapshot()));
2626
return unsubscribe;
27-
}, []);
27+
}, [subscribe, getSnapshot]);
2828
return value;
2929
}
3030

0 commit comments

Comments
 (0)