Commit 06fe616
committed
Revert "Address review comment"
The review comment was based on the incorrect assumption that no dep
declares ship_source_offer. In fact, freetds, openscap, attr, acl,
libsepol, systemd, gpg-error and gcrypt do — but none of them are in
the Windows dep graph.
On Windows, offers_dir is therefore always empty. rules_python 1.9.0
makes `bazel run` copy runfiles to a fresh temp dir and skips empty
dirs, causing pkg_install to fail with FileNotFoundError. The select()
correctly excluded the offers directory on Windows to avoid this.
This reverts commit bc7bb876b618341b1749cf6a38eec2d95d91a8a3.1 parent 2c3e594 commit 06fe616
1 file changed
Lines changed: 8 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
72 | 75 | | |
73 | 76 | | |
74 | 77 | | |
| |||
0 commit comments