Bug Description
In the periodic server refresh goroutine in proxy.go, the error from serversInfo.refresh() is silently discarded using the blank identifier. This error contains information about which servers failed and why.
Affected Code
proxy.go:331:
liveServers, _ = proxy.serversInfo.refresh(proxy)
Impact
Diagnostic information about server failures is lost. If all servers fail, liveServers will be 0, but the reason for the failure is not logged, making debugging difficult.
Fix
Log the error:
liveServers, err = proxy.serversInfo.refresh(proxy)
if err != nil {
dlog.Warnf("Server refresh error: %v", err)
}
Bug Description
In the periodic server refresh goroutine in
proxy.go, the error fromserversInfo.refresh()is silently discarded using the blank identifier. This error contains information about which servers failed and why.Affected Code
proxy.go:331:Impact
Diagnostic information about server failures is lost. If all servers fail,
liveServerswill be 0, but the reason for the failure is not logged, making debugging difficult.Fix
Log the error: