From 9a8473fe43748e303a959ffc6a2f9a86ed415d58 Mon Sep 17 00:00:00 2001 From: Alexander Bushkin Date: Fri, 12 Jun 2026 15:34:57 +0200 Subject: [PATCH 1/3] Resolves JIRA issue CMP-4338: Updated the audit rules to properly handle the RHCOS4 audit system configuration (which supports rhel8-rhel10). --- shared/checks/oval/audit_rules_auditctl.xml | 19 +++++++++++++++++++ shared/checks/oval/audit_rules_augenrules.xml | 19 +++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/shared/checks/oval/audit_rules_auditctl.xml b/shared/checks/oval/audit_rules_auditctl.xml index 27a4e5489599..5e916d897e7c 100644 --- a/shared/checks/oval/audit_rules_auditctl.xml +++ b/shared/checks/oval/audit_rules_auditctl.xml @@ -8,11 +8,30 @@ Test if auditctl is in use for audit rules. +{{% if product in ['ocp4', 'rhcos4'] %}} + + + + +{{% else %}} +{{% endif %}} +{{% if product in ['ocp4', 'rhcos4'] %}} + + + + + + /usr/lib/systemd/system/audit-rules.service + ^ExecStart=\/sbin\/auditctl.*$ + 1 + +{{% endif %}} + diff --git a/shared/checks/oval/audit_rules_augenrules.xml b/shared/checks/oval/audit_rules_augenrules.xml index 7b46a1c9f136..570a0f23b65b 100644 --- a/shared/checks/oval/audit_rules_augenrules.xml +++ b/shared/checks/oval/audit_rules_augenrules.xml @@ -8,11 +8,30 @@ Test if augenrules is enabled for audit rules. +{{% if product in ['ocp4', 'rhcos4'] %}} + + + + +{{% else %}} +{{% endif %}} +{{% if product in ['ocp4', 'rhcos4'] %}} + + + + + + /usr/lib/systemd/system/audit-rules.service + ^ExecStart=(\/usr|)?\/sbin\/augenrules.*$ + 1 + +{{% endif %}} + From 440aa2cb3b2ec2a377d40e69bc0c4e3e830ca8b9 Mon Sep 17 00:00:00 2001 From: Alexander Bushkin Date: Fri, 12 Jun 2026 15:57:30 +0200 Subject: [PATCH 2/3] Modified these files to fix the typo of having 'access' mispelled as 'acccess'. Doesn't currently break anything, but better to fix for correctness' sake. --- .../oval/shared.xml | 16 ++++++++-------- .../oval/shared.xml | 16 ++++++++-------- .../oval/shared.xml | 16 ++++++++-------- .../oval/shared.xml | 10 +++++----- 4 files changed, 29 insertions(+), 29 deletions(-) diff --git a/applications/openshift/logging/directory_access_var_log_kube_audit/oval/shared.xml b/applications/openshift/logging/directory_access_var_log_kube_audit/oval/shared.xml index f6137380bd5d..314f48ff17d2 100644 --- a/applications/openshift/logging/directory_access_var_log_kube_audit/oval/shared.xml +++ b/applications/openshift/logging/directory_access_var_log_kube_audit/oval/shared.xml @@ -7,13 +7,13 @@ - + - + @@ -26,10 +26,10 @@ - + comment="defined audit rule must exist" id="test_directory_access_var_log_kube_audit_augenrules" version="1"> + - + ^/etc/audit/rules\.d/.*\.rules$ 1 @@ -38,10 +38,10 @@ - + comment="defined audit rule must exist" id="test_directory_access_var_log_kube_audit_auditctl" version="1"> + - + /etc/audit/audit.rules 1 diff --git a/applications/openshift/logging/directory_access_var_log_oauth_audit/oval/shared.xml b/applications/openshift/logging/directory_access_var_log_oauth_audit/oval/shared.xml index c7f1506c2965..a1f75cfb451c 100644 --- a/applications/openshift/logging/directory_access_var_log_oauth_audit/oval/shared.xml +++ b/applications/openshift/logging/directory_access_var_log_oauth_audit/oval/shared.xml @@ -7,13 +7,13 @@ - + - + @@ -26,10 +26,10 @@ - + comment="defined audit rule must exist" id="test_directory_access_var_log_oauth_audit_augenrules" version="1"> + - + ^/etc/audit/rules\.d/.*\.rules$ 1 @@ -38,10 +38,10 @@ - + comment="defined audit rule must exist" id="test_directory_access_var_log_oauth_audit_auditctl" version="1"> + - + /etc/audit/audit.rules 1 diff --git a/applications/openshift/logging/directory_access_var_log_ocp_audit/oval/shared.xml b/applications/openshift/logging/directory_access_var_log_ocp_audit/oval/shared.xml index 579dde10725b..1af2c2d07fcd 100644 --- a/applications/openshift/logging/directory_access_var_log_ocp_audit/oval/shared.xml +++ b/applications/openshift/logging/directory_access_var_log_ocp_audit/oval/shared.xml @@ -7,13 +7,13 @@ - + - + @@ -26,10 +26,10 @@ - + comment="defined audit rule must exist" id="test_directory_access_var_log_ocp_audit_augenrules" version="1"> + - + ^/etc/audit/rules\.d/.*\.rules$ 1 @@ -38,10 +38,10 @@ - + comment="defined audit rule must exist" id="test_directory_access_var_log_ocp_audit_auditctl" version="1"> + - + /etc/audit/audit.rules 1 diff --git a/linux_os/guide/auditing/auditd_configure_rules/directory_access_var_log_audit/oval/shared.xml b/linux_os/guide/auditing/auditd_configure_rules/directory_access_var_log_audit/oval/shared.xml index 245224288fac..9fd0f27c9e9c 100644 --- a/linux_os/guide/auditing/auditd_configure_rules/directory_access_var_log_audit/oval/shared.xml +++ b/linux_os/guide/auditing/auditd_configure_rules/directory_access_var_log_audit/oval/shared.xml @@ -30,7 +30,7 @@ -{{% macro test_directory_acccess_var_log_audit(audit_tool, filepath, bits) %}} +{{% macro test_directory_access_var_log_audit(audit_tool, filepath, bits) %}} @@ -41,9 +41,9 @@ {{% endmacro %}} -{{{ test_directory_acccess_var_log_audit("augenrules", "^/etc/audit/rules\.d/.*\.rules$", "32") }}} -{{{ test_directory_acccess_var_log_audit("augenrules", "^/etc/audit/rules\.d/.*\.rules$", "64") }}} -{{{ test_directory_acccess_var_log_audit("auditctl", "/etc/audit/audit.rules", "32") }}} -{{{ test_directory_acccess_var_log_audit("auditctl", "/etc/audit/audit.rules", "64") }}} +{{{ test_directory_access_var_log_audit("augenrules", "^/etc/audit/rules\.d/.*\.rules$", "32") }}} +{{{ test_directory_access_var_log_audit("augenrules", "^/etc/audit/rules\.d/.*\.rules$", "64") }}} +{{{ test_directory_access_var_log_audit("auditctl", "/etc/audit/audit.rules", "32") }}} +{{{ test_directory_access_var_log_audit("auditctl", "/etc/audit/audit.rules", "64") }}} From c086a445b6483ac0cd2692768150cd71bd1f17b8 Mon Sep 17 00:00:00 2001 From: Alexander Bushkin Date: Fri, 12 Jun 2026 17:35:18 +0200 Subject: [PATCH 3/3] Removed ocp4 tags from conditionals. --- shared/checks/oval/audit_rules_auditctl.xml | 4 ++-- shared/checks/oval/audit_rules_augenrules.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/shared/checks/oval/audit_rules_auditctl.xml b/shared/checks/oval/audit_rules_auditctl.xml index 5e916d897e7c..a08a43310046 100644 --- a/shared/checks/oval/audit_rules_auditctl.xml +++ b/shared/checks/oval/audit_rules_auditctl.xml @@ -8,7 +8,7 @@ Test if auditctl is in use for audit rules. -{{% if product in ['ocp4', 'rhcos4'] %}} +{{% if product in ['rhcos4'] %}} @@ -20,7 +20,7 @@ {{% endif %}} -{{% if product in ['ocp4', 'rhcos4'] %}} +{{% if product in ['rhcos4'] %}} diff --git a/shared/checks/oval/audit_rules_augenrules.xml b/shared/checks/oval/audit_rules_augenrules.xml index 570a0f23b65b..92620913a0d9 100644 --- a/shared/checks/oval/audit_rules_augenrules.xml +++ b/shared/checks/oval/audit_rules_augenrules.xml @@ -8,7 +8,7 @@ Test if augenrules is enabled for audit rules. -{{% if product in ['ocp4', 'rhcos4'] %}} +{{% if product in ['rhcos4'] %}} @@ -20,7 +20,7 @@ {{% endif %}} -{{% if product in ['ocp4', 'rhcos4'] %}} +{{% if product in ['rhcos4'] %}}