Improved support for Codeception 5/PHP 8 (#55)

Author: yesdevnull

.gitattributes

@@ -2,6 +2,5 @@
 /tests           export-ignore
 /.gitattributes  export-ignore
 /.gitignore      export-ignore
-/Robofile.php    export-ignore
 /*.md            export-ignore
 /*.yml           export-ignore

composer.json

@@ -1,24 +1,26 @@
 {
     "name": "codeception/module-doctrine2",
     "description": "Doctrine2 module for Codeception",
-    "keywords": [ "codeception", "doctrine2" ],
-    "homepage": "https://codeception.com/",
-    "type": "library",
     "license": "MIT",
+    "type": "library",
+    "keywords": [
+        "codeception",
+        "doctrine2"
+    ],
     "authors": [
         {
-            "name":"Michael Bodnarchuk"
+            "name": "Michael Bodnarchuk"
         },
         {
-            "name":"Alex Kunin"
+            "name": "Alex Kunin"
         }
     ],
-    "minimum-stability": "dev",
+    "homepage": "https://codeception.com/",
     "require": {
         "php": "^8.0",
-        "ext-pdo": "*",
         "ext-json": "*",
-        "codeception/codeception": "dev-5.0-interfaces as 5.0.x-dev"
+        "ext-pdo": "*",
+        "codeception/codeception": "dev-5.0-interfaces as 5.0.0"
     },
     "require-dev": {
         "codeception/stub": "^4.0",
@@ -27,10 +29,16 @@
         "doctrine/orm": "^2.10",
         "phpstan/phpstan": "^1.0",
         "ramsey/uuid-doctrine": "^1.6",
-        "symfony/cache": "^4.4 | ^5.4 | ^6.0"
+        "symfony/cache": "^4.4 || ^5.4 || ^6.0"
     },
+    "conflict": {
+        "codeception/codeception": "<5.0"
+    },
+    "minimum-stability": "dev",
     "autoload": {
-        "classmap": [ "src/" ]
+        "classmap": [
+            "src/"
+        ]
     },
     "config": {
         "classmap-authoritative": true,

phpstan-baseline.neon

@@ -1,6 +1,3 @@
-includes:
-    - phpstan-baseline.neon
-
 parameters:
   level: 6
   paths:
@@ -12,7 +9,7 @@ parameters:
         - tests/data/doctrine2_fixtures/TestFixture2.php
         - tests/_support/UnitTester.php
   checkMissingIterableValueType: false
-  reportUnmatchedIgnoredErrors: false
+  reportUnmatchedIgnoredErrors: true
   ignoreErrors:
       - path: tests/
         message: '#Property \S+ is never read, only written#'

phpstan.neon

@@ -138,9 +138,11 @@
  */
 class Doctrine2 extends CodeceptionModule implements DependsOnModule, DataMapper
 {
-
     private ?DoctrineProvider $dependentModule = null;
 
+    /**
+     * @var array<string, mixed>
+     */
     protected array $config = [
         'cleanup' => true,
         'connection_callback' => false,
@@ -908,7 +910,7 @@ public function grabFromRepository(string $entity, string $field, array $params
      * $users = $I->grabEntitiesFromRepository(User::class, ['name' => 'davert']);
      * ```
      *
-     * @template T
+     * @template T of object
      * @param class-string<T> $entity
      * @param array $params . For `IS NULL`, use `['field' => null]`
      * @return list<T>
@@ -938,7 +940,7 @@ public function grabEntitiesFromRepository(string $entity, array $params = []):
      * $user = $I->grabEntityFromRepository(User::class, ['id' => '1234']);
      * ```
      *
-     * @template T
+     * @template T of object
      * @param class-string<T> $entity
      * @param array $params . For `IS NULL`, use `['field' => null]`
      * @return T
@@ -1006,7 +1008,7 @@ private function debugEntityCreation(object $instance, $pks): void
         $message = get_class($instance) . ' entity created with ';
 
         if (!is_array($pks)) {
-            $pks     = [$pks];
+            $pks = [$pks];
             $message .= 'primary key ';
         } else {
             $message .= 'composite primary key of ';
@@ -1023,10 +1025,7 @@ private function debugEntityCreation(object $instance, $pks): void
         $this->debug(trim($message, ' ,'));
     }
 
-    /**
-     * @param mixed $pk
-     */
-    private function isDoctrineEntity($pk): bool
+    private function isDoctrineEntity(mixed $pk): bool
     {
         $isEntity = is_object($pk);
 

src/Codeception/Module/Doctrine2.php

@@ -16,10 +16,9 @@
 class ReflectionPropertyAccessor
 {
     /**
-     * @return mixed
      * @throws ReflectionException
      */
-    public function getProperty(object $obj, string $field)
+    public function getProperty(object $obj, string $field): mixed
     {
         $class = get_class($obj);
         do {