Fix linter complaints.

Author: CodeReclaimers

sketch_adapter_solidworks/adapter.py

@@ -881,13 +881,12 @@ def _find_sketch_point_by_coords(self, element_id: str, point_type: PointType) -
         entity_index = self._entity_to_id.get(id(entity))
         if entity_index is None:
             # Try to find by searching through entities
-            for idx, geom in enumerate(self._segment_geometry_list):
-                # Check if this geometry matches the entity
-                pass
+            # (placeholder for future implementation)
+            pass
 
         # Look up the geometry by element_id
         geom = None
-        for idx, g in enumerate(self._segment_geometry_list):
+        for g in self._segment_geometry_list:
             # Match by checking if the entity at this index is our entity
             # Since we can't compare COM objects reliably, use the stored coordinates
             if g.get('element_id') == element_id:
@@ -897,17 +896,13 @@ def _find_sketch_point_by_coords(self, element_id: str, point_type: PointType) -
         # If we don't have stored geometry with element_id, try matching by index
         if geom is None:
             # Find the entity index in the order we stored it
-            for prim_id, ent in self._id_to_entity.items():
+            for prim_id, _ent in self._id_to_entity.items():
                 if prim_id == element_id:
                     # Find the index of this primitive
                     # We need to track which geometry belongs to which primitive
                     break
 
-            # Fallback: just use the primitive ID to find geometry
-            # The primitive ID should match the order of creation
-            for idx, g in enumerate(self._segment_geometry_list):
-                pass  # Can't reliably match without element_id
-
+            # Can't reliably match without element_id
             return None
 
         # Get the target coordinates based on point type
@@ -1289,11 +1284,9 @@ def _move_point(self, ref: PointRef, new_x: float, new_y: float) -> bool:
 
         # Find the stored geometry
         geom = None
-        geom_idx = None
-        for idx, g in enumerate(self._segment_geometry_list):
+        for g in self._segment_geometry_list:
             if g.get('element_id') == entity_id:
                 geom = g
-                geom_idx = idx
                 break
 
         if geom is None:
@@ -1984,10 +1977,6 @@ def _export_arc(self, segment: Any, construction: bool = False) -> Arc | Circle:
             )
 
         # Otherwise try to export as an arc (original logic for arcs)
-        start_pt = None
-        end_pt = None
-        center_pt = None
-
         if self._sketch is not None and radius is not None:
             try:
                 points = self._get_com_result(self._sketch, "GetSketchPoints2")
@@ -2188,7 +2177,7 @@ def get_solver_status(self) -> tuple[SolverStatus, int]:
                 # Count constraints
                 constraint_dof = 0
                 if relations:
-                    for rel in relations:
+                    for _rel in relations:
                         constraint_dof += 1  # Simplified - each relation removes 1 DOF
 
                 # Estimate status

tests/test_solidworks_roundtrip.py

@@ -1435,19 +1435,19 @@ def test_slot_profile(self, adapter):
         sketch = SketchDocument(name="SlotProfileTest")
 
         # Create a slot: two parallel lines connected by two semicircular arcs
-        l1 = sketch.add_primitive(Line(start=Point2D(20, 0), end=Point2D(80, 0)))
-        l2 = sketch.add_primitive(Line(start=Point2D(80, 40), end=Point2D(20, 40)))
+        sketch.add_primitive(Line(start=Point2D(20, 0), end=Point2D(80, 0)))
+        sketch.add_primitive(Line(start=Point2D(80, 40), end=Point2D(20, 40)))
 
         # Right semicircle
-        arc1 = sketch.add_primitive(Arc(
+        sketch.add_primitive(Arc(
             center=Point2D(80, 20),
             start_point=Point2D(80, 0),
             end_point=Point2D(80, 40),
             ccw=False
         ))
 
         # Left semicircle
-        arc2 = sketch.add_primitive(Arc(
+        sketch.add_primitive(Arc(
             center=Point2D(20, 20),
             start_point=Point2D(20, 40),
             end_point=Point2D(20, 0),
@@ -1470,14 +1470,14 @@ def test_smooth_corner_profile(self, adapter):
         sketch = SketchDocument(name="SmoothCornerTest")
 
         # Create an L-shape with a fillet
-        l1 = sketch.add_primitive(Line(start=Point2D(0, 0), end=Point2D(0, 50)))
-        arc = sketch.add_primitive(Arc(
+        sketch.add_primitive(Line(start=Point2D(0, 0), end=Point2D(0, 50)))
+        sketch.add_primitive(Arc(
             center=Point2D(10, 50),
             start_point=Point2D(0, 50),
             end_point=Point2D(10, 60),
             ccw=True
         ))
-        l2 = sketch.add_primitive(Line(start=Point2D(10, 60), end=Point2D(60, 60)))
+        sketch.add_primitive(Line(start=Point2D(10, 60), end=Point2D(60, 60)))
 
         adapter.create_sketch(sketch.name)
         adapter.load_sketch(sketch)
@@ -1621,8 +1621,8 @@ def test_fully_constrained_rectangle(self, adapter):
         assert len(lines) == 4
 
         # Check horizontal lines are horizontal
-        horizontal_count = sum(1 for l in lines if abs(l.start.y - l.end.y) < 0.5)
-        vertical_count = sum(1 for l in lines if abs(l.start.x - l.end.x) < 0.5)
+        horizontal_count = sum(1 for ln in lines if abs(ln.start.y - ln.end.y) < 0.5)
+        vertical_count = sum(1 for ln in lines if abs(ln.start.x - ln.end.x) < 0.5)
 
         assert horizontal_count == 2, f"Should have 2 horizontal lines, got {horizontal_count}"
         assert vertical_count == 2, f"Should have 2 vertical lines, got {vertical_count}"
@@ -1691,11 +1691,11 @@ def test_arc_tangent_to_two_lines(self, adapter):
         """Test arc tangent to two lines (fillet-like)."""
         sketch = SketchDocument(name="ArcTangent2LinesTest")
 
-        l1 = sketch.add_primitive(Line(start=Point2D(0, 0), end=Point2D(50, 0)))
-        l2 = sketch.add_primitive(Line(start=Point2D(50, 50), end=Point2D(50, 0)))
+        sketch.add_primitive(Line(start=Point2D(0, 0), end=Point2D(50, 0)))
+        sketch.add_primitive(Line(start=Point2D(50, 50), end=Point2D(50, 0)))
 
         # Arc connecting the two lines
-        arc = sketch.add_primitive(Arc(
+        sketch.add_primitive(Arc(
             center=Point2D(50, 0),
             start_point=Point2D(50, 0),
             end_point=Point2D(50, 0),
@@ -1886,7 +1886,7 @@ def test_symmetric_line_endpoints(self, adapter):
         exported = adapter.export_sketch()
 
         lines = [p for p in exported.primitives.values() if isinstance(p, Line)]
-        non_construction = [l for l in lines if not l.construction]
+        non_construction = [ln for ln in lines if not ln.construction]
         assert len(non_construction) >= 2, "Should have at least 2 non-construction lines"
 
     def test_symmetric_circles(self, adapter):
@@ -2004,29 +2004,29 @@ def test_symmetric_rectangle_halves(self, adapter):
         ))
 
         # Create left half of rectangle
-        left_top = sketch.add_primitive(Line(
+        sketch.add_primitive(Line(
             start=Point2D(0, 80),
             end=Point2D(50, 80)
         ))
         left_side = sketch.add_primitive(Line(
             start=Point2D(0, 20),
             end=Point2D(0, 80)
         ))
-        left_bottom = sketch.add_primitive(Line(
+        sketch.add_primitive(Line(
             start=Point2D(0, 20),
             end=Point2D(50, 20)
         ))
 
         # Create right half of rectangle
-        right_top = sketch.add_primitive(Line(
+        sketch.add_primitive(Line(
             start=Point2D(50, 80),
             end=Point2D(100, 80)
         ))
         right_side = sketch.add_primitive(Line(
             start=Point2D(100, 20),
             end=Point2D(100, 80)
         ))
-        right_bottom = sketch.add_primitive(Line(
+        sketch.add_primitive(Line(
             start=Point2D(50, 20),
             end=Point2D(100, 20)
         ))
@@ -2039,5 +2039,5 @@ def test_symmetric_rectangle_halves(self, adapter):
         exported = adapter.export_sketch()
 
         lines = [p for p in exported.primitives.values() if isinstance(p, Line)]
-        non_construction = [l for l in lines if not l.construction]
+        non_construction = [ln for ln in lines if not ln.construction]
         assert len(non_construction) >= 6, "Should have at least 6 non-construction lines"