Updates to mod incompatibility checker

[originalfoo]

I'm pondering making some additional changes to mod incompatibility checker after LABS gets updated to v11, so probably part of v11.1 release:

• Definitions should specify criticality of the incompatibility:
  • Critical - guaranteed to break TM:PE in a bad way
  • Major - likely to break TM:PE but in a recoverable way (diable conflicting mod an things return to normal)
  • Minor - causes some problems but user can choose to ignore
• Might be better to have a class that defines the incompatible mods, rather than txt file
• Critical conflicts will always be checked, regardless of user settings
• Distinction between major/minor is possibly irrelevant but just putting the idea out there for feedback

Thoughts?

[kvakvs]

Moving to code is a good idea. Syntax checks, and severity enum will also be checked by the compiler.
When you display "severity" to the user, they might not pay attention to what it means and will only care whether this run on their game + mods setup? And if you allow them to click ignore the conflicts, many will ignore (and suffer) without remembering the cause.

[originalfoo]

I was thinking the severity would override user choice to varying degrees.

Example:

• Minor - respects user settings in mod options, eg. they can choose to bypass checking
• Major - will always check and warn, but they can choose to ignore
• Critical - will demand the conflict be resolved and game restart before continue

[originalfoo]

Another thing I'd like to add: Detect if multiple TMPE assemblies in the app domain. For example, user switches from LABS to STABLE while game is running = likely to suffer settings loss as game doesn't know which assembly is active. Would be useful to check for that and warn user maybe with button to exit to desktop.

Is it possible to check if there are multiple assemblies in RAM? (cc: @dymanoid)

[krzychu124]

Good idea, you can get list of all assemblies loaded to current AppDomain using AppDomain.CurrentDomain.GetAssemblies() :)

[originalfoo]

I assume Assembly.FullName will be sufficient to check whether there are multiple TMPE in RAM?

[krzychu124]

FullName is string which also contains version of assembly, so you would get false negative result when you compare across different build versions. I would try to find TrafficManager with other version than caller: Assembly.GetName().Name && Assembly.GetName().Version

[dymanoid]

I'd rather suggest using the main module's GUID instead of the version (as you already do for duplicate detection). FullName is not that great, better go with Name and GUID.

[krzychu124]

Info 28.7546777: Something went wrong while checking incompatible mods - see main game log for details.

Incompatible mod detector is failing completely when one or more mods were not instantiated correctly on game init(missing dependencies or other problem) - probably needs try...catch or additional check.

[originalfoo]

I have a try..catch around whole thing currently so the errors probably aren't great. I'll try and improve that for the v11.2 release as it might help track down some broken mods. I should at least be outputting the mod path or something as that would give some way to find mod even if it's not loading in to game properly.