From ed8f05c67071cd2a74b6c29ceafb56cb5e6ffbe3 Mon Sep 17 00:00:00 2001 From: theBlanketBaron Date: Sat, 14 Nov 2026 07:02:24 -0500 Subject: [PATCH] RAL-184: the digest's gate line counts "suites and scenes" From the watchman's read of RAL-181: with every suite recorded, RAL-180's green line said "112 scenes" of what are mostly the QUICK phase's suites (and "1 scenes" for one). The line, and the parser's and the service's bound messages, now say "suites and scenes". Co-Authored-By: Claude Opus 5.5 --- docs/roadmap.md | 3 +++ src/digest.rs | 4 ++-- src/gate_check.rs | 4 ++-- src/gate_log.rs | 4 +++- src/ledger.rs | 2 +- 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/docs/roadmap.md b/docs/roadmap.md index d381d36..7a0eec2 100644 --- a/docs/roadmap.md +++ b/docs/roadmap.md @@ -1430,3 +1430,6 @@ principles named were durable, accurate and reactive. Found in rally 0x7 by plus run alongside; observed only, never changing the result; the browser tests carry those lines to their own standard error, so ci-local's log has them; with tests for a segfault retried, a second failing, and a teardown crash with a stand-in coredumpctl. +- [ ] **RAL-184: The digest's gate line counts "suites and scenes".** From the watchman's read of RAL-181: with every + suite recorded, RAL-180's green line said "112 scenes" of what are mostly the QUICK phase's suites. Done when: the + line, and the parser's and service's bound messages, say "suites and scenes"; with the tests updated. diff --git a/src/digest.rs b/src/digest.rs index 235cc2f..0aa7f08 100644 --- a/src/digest.rs +++ b/src/digest.rs @@ -1524,7 +1524,7 @@ mod tests { "a" | "b" => Verdict::Green { tip: tip.clone(), on_main: true, - summary: "QUICK OK, 3 scenes, 0 failed".into(), + summary: "QUICK OK, 112 suites and scenes, 0 failed".into(), }, "c" => Verdict::Running { tip: "2".repeat(40), @@ -1560,7 +1560,7 @@ mod tests { [ "- DSM-1, DSM-2: landed in 1111111: gated locally, green at 1111111 [observed: \ ~/.local/state/dsm-gates/1111111111111111111111111111111111111111.log names \ - 1111111 (QUICK OK, 3 scenes, 0 failed), its .ok is there, and git shows 1111111 \ + 1111111 (QUICK OK, 112 suites and scenes, 0 failed), its .ok is there, and git shows 1111111 \ on origin/main in ~/Documents/GitHub/Discoteque and holding each]", "- DSM-3: gate running at 2222222 for 50 min [observed: \ ~/.local/state/dsm-gates/2222222222222222222222222222222222222222.log, no .ok \ diff --git a/src/gate_check.rs b/src/gate_check.rs index 0203ec2..5afa6e2 100644 --- a/src/gate_check.rs +++ b/src/gate_check.rs @@ -168,7 +168,7 @@ fn green(log: &GateLog, tip: &str) -> Result { } match log.failures() { (0, 0) => Ok(format!( - "{}{} scenes, 0 failed", + "{}{} suites and scenes, 0 failed", log.quick .as_deref() .map(|q| format!("{q}, ")) @@ -398,7 +398,7 @@ mod tests { Verdict::Green { tip: tip.clone(), on_main: true, - summary: "QUICK OK, 1 scenes, 0 failed".into() + summary: "QUICK OK, 1 suites and scenes, 0 failed".into() } ); } diff --git a/src/gate_log.rs b/src/gate_log.rs index 62f52b8..fa9e49a 100644 --- a/src/gate_log.rs +++ b/src/gate_log.rs @@ -130,7 +130,9 @@ pub fn parse(text: &str, path: &str, sha256: &str, bytes: u64) -> Result= MAX_SCENES { - return Err(format!("the log has more than {MAX_SCENES} scenes")); + return Err(format!( + "the log has more than {MAX_SCENES} suites and scenes" + )); } scenes.push(Scene { scene: scene.chars().take(120).collect(), diff --git a/src/ledger.rs b/src/ledger.rs index 043234e..e54f36c 100644 --- a/src/ledger.rs +++ b/src/ledger.rs @@ -3867,7 +3867,7 @@ fn check_fields(change: &Change) -> Result<(), LedgerError> { } if log.scenes.len() > crate::gate_log::MAX_SCENES { return Err(LedgerError::InvalidChange(format!( - "a gate log records at most {} scenes", + "a gate log records at most {} suites and scenes", crate::gate_log::MAX_SCENES ))); }