Skip to content

Bug/Missing Feature: Soundfont Sample Panning #117

@thomas-xin

Description

@thomas-xin

Re: https://github.com/BlackMIDIDevs/xsynth/blob/master/soundfonts/src/sf2/preset.rs#L148

In xsynth's implementation here, the panning of samples must either be mono, or stereo (-500, 500). However, this is not the case for many soundfonts, and many will use (-400, 400) or other ratios, and the issue with xsynth's assumption means that any such soundfont will refuse to play affected samples at all, resulting in unexpected and inconsistent silence which can be very difficult to debug, as no warning for such cases is presented.

I believe there should at least be tolerance for such cases, and anything >0 should be treated as right pan, anything <0 should be left. Ideally anything set to 0 should also be reinterpreted as mono, if possible.

Thank you for your time, and for the project, as a whole!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions