Skip to content

Hanukkah code review - index.html #1

@alexilyaev

Description

@alexilyaev
  • Top: Remove HTML comments for old IE's, since you're not using them. Check out the latest H5BP:
    https://github.com/h5bp/html5-boilerplate/blob/master/src/index.html
  • Add a <title> for your app
  • You're loading font-awesome from the web, but you already have it src/css/_font-awesome.min.scss (you can delete this)
  • Remove lt IE 7 browsehappy comment
  • .search-box: Remove method and action attributes, since it has a different purpose now
  • #tab-quick-reports - Add some new lines between code blocks to promote readability (like you did in `#tab-my-team-folders)
  • Dropdowns - Use real links, based on the conifg.json or use Handlebars (see Bonus section https://docs.google.com/document/d/1V5Vvjc_IUeUPBgadphR9gy0f559Pe2BLpkf3QT0m5g8)
    • Should open in new tab
  • #tab-fmy-folders, #content-my-team-folders - Add the iframe URL only when the user enters the tab (if it's not already loaded) That way the home page will load quicker
  • btn-expand should open the URL in a new tab
  • cancel should do the same as clicking btn-settings and not hide the background as well

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions