extract shared resolve_file_changes helper reducing duplication across diff.rs, review.rds, changelog.rs consolidated normalize_extts. Config changesi n risk assessment, now considers modified config/data as medium risk instead of silently falling through to low. Richer CommitInfo.

Author: antiartificial

.gitignore

@@ -2,3 +2,4 @@ node_modules/
 dist/
 .sem/
 *.db
+docs-vitepress/

crates/sem-cli/src/commands/changelog.rs

@@ -1,16 +1,15 @@
 use std::path::Path;
-use std::process;
 
 use colored::Colorize;
-use sem_core::git::bridge::GitBridge;
-use sem_core::git::types::DiffScope;
 use sem_core::parser::changelog::{
     build_changelog, render_markdown, ChangelogResult,
 };
 use sem_core::parser::differ::compute_semantic_diff;
 use sem_core::parser::graph::EntityGraph;
 use sem_core::parser::plugins::create_default_registry;
 
+use super::common::{self, open_git_or_exit};
+
 pub struct ChangelogOptions {
     pub cwd: String,
     pub from: Option<String>,
@@ -34,67 +33,16 @@ pub enum ChangelogFormat {
 pub fn changelog_command(opts: ChangelogOptions) {
     let root = Path::new(&opts.cwd);
     let registry = create_default_registry();
+    let git = open_git_or_exit(root);
 
-    let git = match GitBridge::open(root) {
-        Ok(g) => g,
-        Err(_) => {
-            eprintln!("\x1b[31mError: Not inside a Git repository.\x1b[0m");
-            process::exit(1);
-        }
-    };
-
-    // Get file changes
-    let file_changes = if let Some(ref sha) = opts.commit {
-        let scope = DiffScope::Commit { sha: sha.clone() };
-        match git.get_changed_files(&scope) {
-            Ok(files) => files,
-            Err(e) => {
-                eprintln!("\x1b[31mError: {e}\x1b[0m");
-                process::exit(1);
-            }
-        }
-    } else if let (Some(ref from), Some(ref to)) = (&opts.from, &opts.to) {
-        let scope = DiffScope::Range {
-            from: from.clone(),
-            to: to.clone(),
-        };
-        match git.get_changed_files(&scope) {
-            Ok(files) => files,
-            Err(e) => {
-                eprintln!("\x1b[31mError: {e}\x1b[0m");
-                process::exit(1);
-            }
-        }
-    } else if opts.staged {
-        let scope = DiffScope::Staged;
-        match git.get_changed_files(&scope) {
-            Ok(files) => files,
-            Err(e) => {
-                eprintln!("\x1b[31mError: {e}\x1b[0m");
-                process::exit(1);
-            }
-        }
-    } else {
-        match git.detect_and_get_files() {
-            Ok((_scope, files)) => files,
-            Err(_) => {
-                eprintln!("\x1b[31mError: Not inside a Git repository.\x1b[0m");
-                process::exit(1);
-            }
-        }
-    };
-
-    // Filter by extensions
-    let file_changes = if opts.file_exts.is_empty() {
-        file_changes
-    } else {
-        let exts: Vec<String> = opts.file_exts.iter().map(|e| {
-            if e.starts_with('.') { e.clone() } else { format!(".{}", e) }
-        }).collect();
-        file_changes.into_iter().filter(|fc| {
-            exts.iter().any(|ext| fc.file_path.ends_with(ext.as_str()))
-        }).collect()
-    };
+    let file_changes = common::resolve_file_changes(
+        &git,
+        opts.commit.as_deref(),
+        opts.from.as_deref(),
+        opts.to.as_deref(),
+        opts.staged,
+    );
+    let file_changes = common::filter_by_exts(file_changes, &opts.file_exts);
 
     if file_changes.is_empty() {
         println!("{}", "No changes detected.".dimmed());
@@ -110,7 +58,7 @@ pub fn changelog_command(opts: ChangelogOptions) {
     }
 
     // Build entity graph
-    let ext_filter = super::graph::normalize_exts(&opts.file_exts);
+    let ext_filter = common::normalize_exts(&opts.file_exts);
     let all_files = sem_core::utils::files::find_supported_files(root, &registry, &ext_filter);
     let graph = EntityGraph::build(root, &all_files, &registry);
 

crates/sem-cli/src/commands/common.rs

@@ -0,0 +1,90 @@
+use std::path::Path;
+use std::process;
+
+use sem_core::git::bridge::GitBridge;
+use sem_core::git::types::{DiffScope, FileChange};
+
+/// Resolve file changes from git based on CLI options.
+pub fn resolve_file_changes(
+    git: &GitBridge,
+    commit: Option<&str>,
+    from: Option<&str>,
+    to: Option<&str>,
+    staged: bool,
+) -> Vec<FileChange> {
+    if let Some(sha) = commit {
+        let scope = DiffScope::Commit { sha: sha.to_string() };
+        match git.get_changed_files(&scope) {
+            Ok(files) => files,
+            Err(e) => {
+                eprintln!("\x1b[31mError: {e}\x1b[0m");
+                process::exit(1);
+            }
+        }
+    } else if let (Some(f), Some(t)) = (from, to) {
+        let scope = DiffScope::Range {
+            from: f.to_string(),
+            to: t.to_string(),
+        };
+        match git.get_changed_files(&scope) {
+            Ok(files) => files,
+            Err(e) => {
+                eprintln!("\x1b[31mError: {e}\x1b[0m");
+                process::exit(1);
+            }
+        }
+    } else if staged {
+        let scope = DiffScope::Staged;
+        match git.get_changed_files(&scope) {
+            Ok(files) => files,
+            Err(e) => {
+                eprintln!("\x1b[31mError: {e}\x1b[0m");
+                process::exit(1);
+            }
+        }
+    } else {
+        match git.detect_and_get_files() {
+            Ok((_scope, files)) => files,
+            Err(_) => {
+                eprintln!("\x1b[31mError: Not inside a Git repository.\x1b[0m");
+                process::exit(1);
+            }
+        }
+    }
+}
+
+/// Open a GitBridge or exit with an error.
+pub fn open_git_or_exit(root: &Path) -> GitBridge {
+    match GitBridge::open(root) {
+        Ok(g) => g,
+        Err(_) => {
+            eprintln!("\x1b[31mError: Not inside a Git repository.\x1b[0m");
+            process::exit(1);
+        }
+    }
+}
+
+/// Normalize extension strings to have a leading dot.
+pub fn normalize_exts(exts: &[String]) -> Vec<String> {
+    exts.iter()
+        .map(|e| {
+            if e.starts_with('.') {
+                e.clone()
+            } else {
+                format!(".{}", e)
+            }
+        })
+        .collect()
+}
+
+/// Filter file changes by extension.
+pub fn filter_by_exts(file_changes: Vec<FileChange>, exts: &[String]) -> Vec<FileChange> {
+    if exts.is_empty() {
+        return file_changes;
+    }
+    let normalized = normalize_exts(exts);
+    file_changes
+        .into_iter()
+        .filter(|fc| normalized.iter().any(|ext| fc.file_path.ends_with(ext.as_str())))
+        .collect()
+}

crates/sem-cli/src/commands/diff.rs

@@ -3,11 +3,11 @@ use std::path::Path;
 use std::process;
 use std::time::Instant;
 
-use sem_core::git::bridge::GitBridge;
-use sem_core::git::types::{DiffScope, FileChange};
+use sem_core::git::types::FileChange;
 use sem_core::parser::differ::compute_semantic_diff;
 use sem_core::parser::plugins::create_default_registry;
 
+use super::common::{self, open_git_or_exit};
 use crate::formatters::{json::format_json, terminal::format_terminal};
 
 pub struct DiffOptions {
@@ -71,68 +71,19 @@ pub fn diff_command(opts: DiffOptions) {
         });
         (changes, true)
     } else {
-        let git = match GitBridge::open(Path::new(&opts.cwd)) {
-            Ok(g) => g,
-            Err(_) => {
-                eprintln!("\x1b[31mError: Not inside a Git repository.\x1b[0m");
-                process::exit(1);
-            }
-        };
-
-        let (_scope, file_changes) = if let Some(ref sha) = opts.commit {
-            let scope = DiffScope::Commit { sha: sha.clone() };
-            match git.get_changed_files(&scope) {
-                Ok(files) => (scope, files),
-                Err(e) => {
-                    eprintln!("\x1b[31mError: {e}\x1b[0m");
-                    process::exit(1);
-                }
-            }
-        } else if let (Some(ref from), Some(ref to)) = (&opts.from, &opts.to) {
-            let scope = DiffScope::Range {
-                from: from.clone(),
-                to: to.clone(),
-            };
-            match git.get_changed_files(&scope) {
-                Ok(files) => (scope, files),
-                Err(e) => {
-                    eprintln!("\x1b[31mError: {e}\x1b[0m");
-                    process::exit(1);
-                }
-            }
-        } else if opts.staged {
-            let scope = DiffScope::Staged;
-            match git.get_changed_files(&scope) {
-                Ok(files) => (scope, files),
-                Err(e) => {
-                    eprintln!("\x1b[31mError: {e}\x1b[0m");
-                    process::exit(1);
-                }
-            }
-        } else {
-            match git.detect_and_get_files() {
-                Ok((scope, files)) => (scope, files),
-                Err(_) => {
-                    eprintln!("\x1b[31mError: Not inside a Git repository.\x1b[0m");
-                    process::exit(1);
-                }
-            }
-        };
+        let git = open_git_or_exit(Path::new(&opts.cwd));
+        let file_changes = common::resolve_file_changes(
+            &git,
+            opts.commit.as_deref(),
+            opts.from.as_deref(),
+            opts.to.as_deref(),
+            opts.staged,
+        );
         (file_changes, false)
     };
     let git_diff_ms = t0.elapsed().as_secs_f64() * 1000.0;
 
-    // Filter by file extensions if specified
-    let file_changes = if opts.file_exts.is_empty() {
-        file_changes
-    } else {
-        let exts: Vec<String> = opts.file_exts.iter().map(|e| {
-            if e.starts_with('.') { e.clone() } else { format!(".{}", e) }
-        }).collect();
-        file_changes.into_iter().filter(|fc| {
-            exts.iter().any(|ext| fc.file_path.ends_with(ext.as_str()))
-        }).collect()
-    };
+    let file_changes = common::filter_by_exts(file_changes, &opts.file_exts);
 
     if file_changes.is_empty() {
         println!("\x1b[2mNo changes detected.\x1b[0m");

crates/sem-cli/src/commands/graph.rs

@@ -21,7 +21,7 @@ pub fn graph_command(opts: GraphOptions) {
     let root = Path::new(&opts.cwd);
     let registry = create_default_registry();
 
-    let ext_filter = normalize_exts(&opts.file_exts);
+    let ext_filter = super::common::normalize_exts(&opts.file_exts);
 
     // If no files specified, find all supported files in the repo
     let file_paths = if opts.file_paths.is_empty() {
@@ -231,10 +231,3 @@ fn ref_symbol(ref_type: &RefType) -> colored::ColoredString {
         RefType::Imports => "↓".green(),
     }
 }
-
-/// Normalize extension strings: ensure each starts with '.'
-pub fn normalize_exts(exts: &[String]) -> Vec<String> {
-    exts.iter().map(|e| {
-        if e.starts_with('.') { e.clone() } else { format!(".{}", e) }
-    }).collect()
-}

crates/sem-cli/src/commands/impact.rs

@@ -16,7 +16,7 @@ pub fn impact_command(opts: ImpactOptions) {
     let root = Path::new(&opts.cwd);
     let registry = create_default_registry();
 
-    let ext_filter = super::graph::normalize_exts(&opts.file_exts);
+    let ext_filter = super::common::normalize_exts(&opts.file_exts);
 
     // If no files specified, find all supported files in the repo
     let file_paths = if opts.file_paths.is_empty() {

crates/sem-cli/src/commands/mod.rs

@@ -1,5 +1,6 @@
 pub mod blame;
 pub mod changelog;
+pub mod common;
 pub mod diff;
 pub mod graph;
 pub mod impact;