Skip to content

Tweaks: "Hide filtered posts entirely" breaks if endless scrolling is disabled #2284

@marcustyphoon

Description

@marcustyphoon

Platform

macOS 14.8.7 arm64

Browser

Firefox 150.0.3

Addon version

v1.3.4

Details

Filtered posts aren't hidden if endless scrolling is disabled. Sorry everyone! This is due to a bug in a change I made in #2132.

(I actually commented about that specific line change being kind of weird, but I thought it was fine and tested it. Turns out I didn't test it without endless scrolling on, which would have shown that this ultimately surfaces another bug: our getTimelineItemWrapper function isn't idempotent if one has endless scrolling disabled, and we're calling it twice.)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

Status
In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions