Skip to content

Mutual Checker only-mutuals: Timelines may not be scrollable #2274

@marcustyphoon

Description

@marcustyphoon

Platform

n/a (I did not test the behavior)

Browser

n/a (I did not test the behavior)

Addon version

v1.3.3

Details

In Show Originals and Seen Posts, we implement a lengthenTimelines() function that sets min-height: 100vh; on affected timeline elements, ensuring that if the feature hides an entire page of results and a user has endless scrolling on, the user can scroll to fetch the next page. Without this, it becomes impossible to load any posts.

Mutual Checker's only-mutuals mode can quite easily result in this scenario (per user report), but it lacks equivalent code, so it suffers from this problem.

(I thought about whether it could make sense to unify the code that does this in one location. The post hiding utility file we just made seems like an obvious place to put this if we do so. It, though, is currently used in features that don't use the post hiding utility, and so it would probably have to be a separate export, which might be kind of odd. But then, maybe not! const { lengthenTimeline, unlengthenTimeline } = createLengthenTimelineFunctions({ id: 'mutual-checker' });)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

    Projects

    Status
    Untriaged

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions