Frequent crashes (case not yet known)

[WhyNotHugo]

Describe the bug
Every once in a while, waybar crashes. I still haven't found the root cause; opening an issue to collect information in one place.

To reproduce
Unclear thus far.

Environment

• Waybar version: Waybar v0.15.0
• Installed from: Alpine Linux
• Compositor and version: swaywm

Debug output

#0  __restore_sigs (set=set@entry=0x7fffee535950) at ./arch/x86_64/syscall_arch.h:40
#1  0x00007ffff7fb60f5 in raise (sig=sig@entry=6) at src/signal/raise.c:11
#2  0x00007ffff7f996de in abort () at src/exit/abort.c:11
#3  0x00007ffff66cb51f in __gnu_cxx::__verbose_terminate_handler() () at /lib/libstdc++.so.6
#4  0x00007ffff66c9228 in __cxxabiv1::__terminate(void (*)()) () at /lib/libstdc++.so.6
#5  0x00007ffff66b057c in std::terminate() () at /lib/libstdc++.so.6
#6  0x00007ffff66c94d8 in __cxa_throw () at /lib/libstdc++.so.6
#7  0x00005555555e4828 in waybar::modules::Battery::refreshBatteries (this=0x7ffff4024020)
    at /usr/include/c++/15.2.0/bits/allocator.h:189
#8  0x00005555555e5501 in operator() (__closure=0x7ffff3f96290) at ../src/modules/battery.cpp:94
#9  std::__invoke_impl<void, waybar::modules::Battery::worker()::<lambda()>&> (__f=...) at /usr/include/c++/15.2.0/bits/invoke.h:63
#10 std::__invoke_r<void, waybar::modules::Battery::worker()::<lambda()>&> (__fn=...) at /usr/include/c++/15.2.0/bits/invoke.h:113
#11 std::_Function_handler<void(), waybar::modules::Battery::worker()::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...)
    at /usr/include/c++/15.2.0/bits/std_function.h:292
#12 0x00005555555a7533 in std::function<void()>::operator() (this=0x7ffff3f96290) at /usr/include/c++/15.2.0/bits/std_function.h:593
#13 waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}::operator()() const (__closure=0x7ffff3f96288)
    at ../include/util/sleeper_thread.hpp:48
#14 std::__invoke_impl<void, waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}>(std::__invoke_other, waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}&&) (__f=...) at /usr/include/c++/15.2.0/bits/invoke.h:63
#15 std::__invoke<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}>(waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}&&) (__fn=...) at /usr/include/c++/15.2.0/bits/invoke.h:98
#16 std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> >::_M_invoke<0ul>(std::_Index_tuple<0ul>) (this=0x7ffff3f96288) at /usr/include/c++/15.2.0/bits/std_thread.h:303
#17 std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> >::operator()()
    (this=0x7ffff3f96288) at /usr/include/c++/15.2.0/bits/std_thread.h:310
#18 std::thread::_State_impl<std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> > >::_M_run() (this=0x7ffff3f96280) at /usr/include/c++/15.2.0/bits/std_thread.h:255
#19 0x00007ffff66fa680 in ??? () at /lib/libstdc++.so.6
#20 0x00007ffff7fbef6d in start (p=<optimized out>) at src/thread/pthread_create.c:207
#21 0x00007ffff7fc08c0 in __clone () at src/thread/x86_64/clone.s:22

Additional context
The timing seems to align with my mouse disconnecting for unknown reasons; unclear if there's a correlation.

[WhyNotHugo]

Backtrace with catch throw:

#0  0x00007ffff66c9490 in __cxa_throw () at /lib/libstdc++.so.6
#1  0x00007ffff66b5925 in std::__throw_ios_failure(char const*, int) () at /lib/libstdc++.so.6
#2  0x00007ffff6742e49 in std::basic_filebuf<char, std::char_traits<char> >::underflow() () at /lib/libstdc++.so.6
#3  0x00007ffff674fe19 in std::basic_istream<char, std::char_traits<char> >::sentry::sentry(std::basic_istream<char, std::char_traits<char> >&, bool) () at /lib/libstdc++.so.6
#4  0x00007ffff66e75d7 in std::basic_istream<char, std::char_traits<char> >& std::operator>><char, std::char_traits<char>, std::allocator<char> >(std::basic_istream<char, std::char_traits<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) () at /lib/libstdc++.so.6
#5  0x00005555555e4688 in std::operator>><std::basic_ifstream<char, std::char_traits<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> (__is=..., __x=...) at /usr/include/c++/15.2.0/istream:1101
#6  waybar::modules::Battery::refreshBatteries (this=0x7ffff4026030) at ../src/modules/battery.cpp:129
#7  0x00005555555e5501 in operator() (__closure=0x7ffff3dfa800) at ../src/modules/battery.cpp:94
#8  std::__invoke_impl<void, waybar::modules::Battery::worker()::<lambda()>&> (__f=...) at /usr/include/c++/15.2.0/bits/invoke.h:63
#9  std::__invoke_r<void, waybar::modules::Battery::worker()::<lambda()>&> (__fn=...) at /usr/include/c++/15.2.0/bits/invoke.h:113
#10 std::_Function_handler<void(), waybar::modules::Battery::worker()::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...)
    at /usr/include/c++/15.2.0/bits/std_function.h:292
#11 0x00005555555a7533 in std::function<void()>::operator() (this=0x7ffff3dfa800) at /usr/include/c++/15.2.0/bits/std_function.h:593
#12 waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}::operator()() const (__closure=0x7ffff3dfa7f8)
    at ../include/util/sleeper_thread.hpp:48
#13 std::__invoke_impl<void, waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}>(std::__invoke_other, waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}&&) (__f=...) at /usr/include/c++/15.2.0/bits/invoke.h:63
#14 std::__invoke<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}>(waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}&&) (__fn=...) at /usr/include/c++/15.2.0/bits/invoke.h:98
#15 std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> >::_M_invoke<0ul>(std::_Index_tuple<0ul>) (this=0x7ffff3dfa7f8) at /usr/include/c++/15.2.0/bits/std_thread.h:303
#16 std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> >::operator()()
    (this=0x7ffff3dfa7f8) at /usr/include/c++/15.2.0/bits/std_thread.h:310
#17 std::thread::_State_impl<std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> > >::_M_run() (this=0x7ffff3dfa7f0) at /usr/include/c++/15.2.0/bits/std_thread.h:255
#18 0x00007ffff66fa680 in ??? () at /lib/libstdc++.so.6
#19 0x00007ffff7fbef6d in start (p=<optimized out>) at src/thread/pthread_create.c:207
#20 0x00007ffff7fc08c0 in __clone () at src/thread/x86_64/clone.s:22

After continue:

#0  0x00007ffff66c9490 in __cxa_throw () at /lib/libstdc++.so.6
#1  0x00007ffff66b5925 in std::__throw_ios_failure(char const*, int) () at /lib/libstdc++.so.6
#2  0x00007ffff6742e49 in std::basic_filebuf<char, std::char_traits<char> >::underflow() () at /lib/libstdc++.so.6
#3  0x00007ffff674fe19 in std::basic_istream<char, std::char_traits<char> >::sentry::sentry(std::basic_istream<char, std::char_traits<char> >&, bool) () at /lib/libstdc++.so.6
#4  0x00007ffff66e75d7 in std::basic_istream<char, std::char_traits<char> >& std::operator>><char, std::char_traits<char>, std::allocator<char> >(std::basic_istream<char, std::char_traits<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) () at /lib/libstdc++.so.6
#5  0x00005555555e4688 in std::operator>><std::basic_ifstream<char, std::char_traits<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> (__is=..., __x=...) at /usr/include/c++/15.2.0/istream:1101
#6  waybar::modules::Battery::refreshBatteries (this=0x7fffee0e6220) at ../src/modules/battery.cpp:129
#7  0x00005555555e5501 in operator() (__closure=0x7fffee0fbae0) at ../src/modules/battery.cpp:94
#8  std::__invoke_impl<void, waybar::modules::Battery::worker()::<lambda()>&> (__f=...) at /usr/include/c++/15.2.0/bits/invoke.h:63
#9  std::__invoke_r<void, waybar::modules::Battery::worker()::<lambda()>&> (__fn=...) at /usr/include/c++/15.2.0/bits/invoke.h:113
#10 std::_Function_handler<void(), waybar::modules::Battery::worker()::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...)
    at /usr/include/c++/15.2.0/bits/std_function.h:292
#11 0x00005555555a7533 in std::function<void()>::operator() (this=0x7fffee0fbae0) at /usr/include/c++/15.2.0/bits/std_function.h:593
#12 waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}::operator()() const (__closure=0x7fffee0fbad8)
    at ../include/util/sleeper_thread.hpp:48
#13 std::__invoke_impl<void, waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}>(std::__invoke_other, waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}&&) (__f=...) at /usr/include/c++/15.2.0/bits/invoke.h:63
#14 std::__invoke<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}>(waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}&&) (__fn=...) at /usr/include/c++/15.2.0/bits/invoke.h:98
#15 std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> >::_M_invoke<0ul>(std::_Index_tuple<0ul>) (this=0x7fffee0fbad8) at /usr/include/c++/15.2.0/bits/std_thread.h:303
#16 std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> >::operator()()
    (this=0x7fffee0fbad8) at /usr/include/c++/15.2.0/bits/std_thread.h:310
#17 std::thread::_State_impl<std::thread::_Invoker<std::tuple<waybar::util::SleeperThread::operator=(std::function<void ()>)::{lambda()#1}> > >::_M_run() (this=0x7fffee0fbad0) at /usr/include/c++/15.2.0/bits/std_thread.h:255
#18 0x00007ffff66fa680 in ??? () at /lib/libstdc++.so.6
#19 0x00007ffff7fbef6d in start (p=<optimized out>) at src/thread/pthread_create.c:207
#20 0x00007ffff7fc08c0 in __clone () at src/thread/x86_64/clone.s:22

[Mrpaoo]

No mean to add noise, but i remembered i have fixed it , but somehow 59d09c2 just break my fixation.

Related : #4982

[WhyNotHugo]

Yeah, that patch seems aligned with my diagnosis, I'll give it a try.

[Mrpaoo]

Maybe this time, we could update the test to avoid regression., according to hardware.sh. In this case, the basic smoky test maybe:

• make a flaky battery
• remove and re-install it while waybar is running
• assert waybar isn't crash
  we could discuss it detailed in PR:)

[WhyNotHugo]

The issue is gone as of 59d09c2

This is fine to close by me, do you want to keep it open to track your suggested test?