SPIKE: factor out Orch contract core-eval boilerplate#10695
Draft
dckc wants to merge 21 commits into
Draft
Conversation
e084cac to
4a1e603
Compare
295e818 to
4ce1540
Compare
Factor out metainfo so that generic .start.js can get it without getting the whole contract.
reconsider ExtraCorePowers: infer from permit
151c868 to
402792d
Compare
Deploying agoric-sdk with
|
| Latest commit: |
5d5d1eb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8b9266c.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-fu-autostart.agoric-sdk.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs:
Description
Drive most of the core-eval code from
ContractMetaandpermit.permit.issuer.consumepermit.issuer.producemeta.name,permit.issuer.produce,permit.brand.producemeta.adminRolesgeneralizes sending oracle invitationsorchPermit,makePrivateArgs()remains custom code, though only for stuff beyondorchestrationPowersfinishDeploy()remains custom code: forpublishFeedPolicyand callingcreatorFacetmethodspermit is down to ~15 LOC:
agoric-sdk/packages/fast-usdc/src/fast-usdc.contract.meta.js
Lines 84 to 98 in 151c868
In order to keep it type-safe,
metaandpermitare imported. Maybe there's a way to parameterize the types or something so that the custom code can call the boilerplate. hm.DRAFT until:
fast-usdc.start.jstoorch.start.jsand update builders, boot testsSecurity Considerations
This contributes somewhat to...
Scaling Considerations
n/a
Documentation Considerations
should simplify Writing a Core Eval Script to Deploy a Contract
Testing Considerations
For Fast USDC, existing tests should do it. It's essentially a pure refactor, but some of the filenames have runtime impact in builders and such, so it's possible that the changes are visible from tests.
Upgrade Considerations
This could / should make it less likely to mess up saving admin facets.