test: guard sparsekernel mapping uniqueness

Author: AbrahamGreenman

scripts/check-sparsekernel-openapi.mjs

@@ -198,6 +198,7 @@ export function checkSparseKernelOpenApi({ openapiText, daemonSource, clientSour
   const clientPaths = collectClientPaths(clientSource);
   const clientRouteKeys = collectClientRouteKeys(clientSource);
   const openapiRouteKeys = collectOpenApiRouteKeys(paths);
+  checkClientSchemaMappingUniqueness(errors, CLIENT_SCHEMA_MAPPINGS);
 
   pushSetDiff(
     errors,
@@ -574,6 +575,48 @@ function checkClientSchemaProperties(errors, clientSource, schemas) {
   }
 }
 
+function checkClientSchemaMappingUniqueness(errors, mappings) {
+  const { duplicateClientTypes, duplicateSchemaNames } =
+    collectClientSchemaMappingProblems(mappings);
+  if (duplicateClientTypes.length > 0) {
+    errors.push(
+      formatList(
+        "SparseKernel client parity mappings duplicate client types",
+        duplicateClientTypes,
+      ),
+    );
+  }
+  if (duplicateSchemaNames.length > 0) {
+    errors.push(
+      formatList(
+        "SparseKernel client parity mappings duplicate schema names",
+        duplicateSchemaNames,
+      ),
+    );
+  }
+}
+
+export function collectClientSchemaMappingProblems(mappings) {
+  return {
+    duplicateClientTypes: collectDuplicateMappingValues(mappings, "clientType"),
+    duplicateSchemaNames: collectDuplicateMappingValues(mappings, "schemaName"),
+  };
+}
+
+function collectDuplicateMappingValues(mappings, key) {
+  const firstSeen = new Set();
+  const duplicates = new Set();
+  for (const item of mappings) {
+    const value = item[key];
+    if (firstSeen.has(value)) {
+      duplicates.add(value);
+      continue;
+    }
+    firstSeen.add(value);
+  }
+  return [...duplicates].toSorted(compareStrings);
+}
+
 function schemaPropertiesFor(schemas, schemaName) {
   const properties = schemas?.[schemaName]?.properties;
   if (!properties || typeof properties !== "object" || Array.isArray(properties)) {

test/scripts/check-sparsekernel-openapi.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from "vitest";
 import {
+  collectClientSchemaMappingProblems,
   collectOpenApiInlineArrayResponseItemRoutes,
   collectOpenApiInlineObjectResponseSchemaRoutes,
   collectOpenApiInlineRequestBodyRoutes,
@@ -10,6 +11,20 @@ import {
 } from "../../scripts/check-sparsekernel-openapi.mjs";
 
 describe("scripts/check-sparsekernel-openapi", () => {
+  it("finds duplicate client parity mappings", () => {
+    expect(
+      collectClientSchemaMappingProblems([
+        { clientType: "SparseKernelTask", schemaName: "Task" },
+        { clientType: "SparseKernelSession", schemaName: "Session" },
+        { clientType: "SparseKernelTask", schemaName: "TaskInput" },
+        { clientType: "SparseKernelTaskInput", schemaName: "Task" },
+      ]),
+    ).toEqual({
+      duplicateClientTypes: ["SparseKernelTask"],
+      duplicateSchemaNames: ["Task"],
+    });
+  });
+
   it("collects component-backed request body schema names", () => {
     const paths = {
       "/tasks/enqueue": {