Allow generic cosmetic exception

[Yuki2718]

I hope this is correct place to open ticket but please move if not. I want to add filters like #$#ins.adsbygoogle:empty { width:1px!important;height:1px!important;min-height:1px!important; } in my personal list (in conjunction with #@#.adsbygoogle) but currently don't work.

[ameshkov]

Have you marked your personal list as trusted?

[Yuki2718]

Have you marked your personal list as trusted?

It's true even to User rules.

[ameshkov]

What version of AdGuard?

[Yuki2718]

What version of AdGuard?

Chrome Extension 3.5.34 on Brave

[ameshkov]

Hm, any website where I can test this?

[ameshkov]

Tested it with the browser extension and with AG for Mac, no issues found: http://receptive-chairs.surge.sh/

#$#ins.adsbygoogle:empty { width:1px!important;height:1px!important;min-height:1px!important; }
receptive-chairs.surge.sh#@#.adsbygoogle

[ameshkov]

Could it be that your problem is not with generic CSS injection, but with generic CSS exclusion? #@#.adsbygoogle - this one always requires a domain name.

[Yuki2718]

@ameshkov Yeah, working now and I mistook.

Could it be that your problem is not with generic CSS injection, but with generic CSS exclusion? #@#.adsbygoogle - this one always requires a domain name.

Why is it? It's very convenient to "badfilter" a generic cosmetic filter, if the filter is a bait or problematic and also used on too many sites. As an example uBlock filters has had #@#.afs_ads since the class is seen everywhere but mostly used as bait. Sure, in case of EL we can communicate in Slack but such filters may be in other minor lists. Now the only way will be exclusion in FiltersRegistry and end user don't have access to it.

[ameshkov]

Hmm, you know, this seems to be a bug in the browser extension. CoreLibs-based AG works as you explained.

Filed a bug report: AdguardTeam/tsurlfilter#11

We'll backport it to the old extension as well (tsurlfilter library is only used in v4.0 that's not yet production-ready)

[Yuki2718]

@ameshkov Okay, thx for clarification and nice to see it'll be fixed!

[Yuki2718]

I think this is already fixed, isn't it?