AG-54780 Update session_start logic in telemetry service

Author: Zauats

Extension/src/background/services/telemetry/Telemetry.ts

@@ -69,6 +69,12 @@ export class Telemetry {
      */
     private static isSessionStartInProgress = false;
 
+    /**
+     * Flag indicating that session_start has been successfully sent in this
+     * process lifetime.
+     */
+    private static isSessionStartSent = false;
+
     /**
      * Initializes telemetry service.
      *
@@ -257,7 +263,7 @@ export class Telemetry {
      * Prevents concurrent calls to avoid duplicate requests.
      */
     private static async runSessionStart(): Promise<void> {
-        if (!Telemetry.isAnonymizedUsageDataAllowed()) {
+        if (!Telemetry.isAnonymizedUsageDataAllowed() || Telemetry.isSessionStartSent) {
             return;
         }
 
@@ -283,6 +289,7 @@ export class Telemetry {
 
             const response = await TelemetryApi.sendSessionStart(request);
             await ABTestManager.processResponse(response);
+            Telemetry.isSessionStartSent = true;
         } catch (e) {
             logger.debug('[ext.Telemetry.runSessionStart]: session_start failed', e);
         } finally {

tests/src/background/telemetry/Telemetry.test.ts

@@ -50,6 +50,7 @@ vi.mock('../../../../Extension/src/background/api', () => ({
     },
     TelemetryApi: {
         sendEvent: vi.fn(),
+        sendSessionStart: vi.fn().mockResolvedValue({ versions: {} }),
     },
 }));
 
@@ -99,6 +100,13 @@ describe('Telemetry', () => {
             },
         });
 
+        // Reset session start state so each test starts fresh
+        // @ts-ignore - accessing private field for testing
+        Telemetry.isSessionStartSent = false;
+        // @ts-ignore - accessing private field for testing
+        Telemetry.isSessionStartInProgress = false;
+        vi.mocked(TelemetryApi.sendSessionStart).mockResolvedValue({ versions: {} });
+
         await Telemetry.init();
     });
 
@@ -200,6 +208,37 @@ describe('Telemetry', () => {
         });
     });
 
+    describe('session_start', () => {
+        test('sends session_start during init when telemetry is enabled', async () => {
+            // beforeEach calls init() with telemetry enabled
+            expect(TelemetryApi.sendSessionStart).toHaveBeenCalledTimes(1);
+        });
+
+        test('does not send session_start again on re-init', async () => {
+            vi.clearAllMocks();
+            await Telemetry.init();
+
+            expect(TelemetryApi.sendSessionStart).not.toHaveBeenCalled();
+        });
+
+        test('does not send session_start when telemetry is disabled', async () => {
+            // @ts-ignore - accessing private field for testing
+            Telemetry.isSessionStartSent = false;
+            // @ts-ignore - accessing private field for testing
+            Telemetry.isSessionStartInProgress = false;
+            vi.clearAllMocks();
+            vi.mocked(SettingsApi.getSetting).mockImplementation((key) => {
+                if (key === SettingOption.AllowAnonymizedUsageData) {
+                    return false;
+                }
+                return undefined;
+            });
+            await Telemetry.init();
+
+            expect(TelemetryApi.sendSessionStart).not.toHaveBeenCalled();
+        });
+    });
+
     describe('experiment props', () => {
         test('does not include empty experiment fields in telemetry events', async () => {
             vi.spyOn(ABTestManager, 'getVariantsForProps').mockResolvedValue({});