From db9c4c119679a68cc99e499dfe498deeca780f0b Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 15 Oct 2022 19:07:00 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- pt_datasets/utils.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/pt_datasets/utils.py b/pt_datasets/utils.py index 6b3b540..1270ee2 100644 --- a/pt_datasets/utils.py +++ b/pt_datasets/utils.py @@ -179,7 +179,26 @@ def unzip_dataset(dataset_filename: str) -> None: zip_object.extractall(os.path.join(str(Path.home()), "datasets")) elif dataset_filename.endswith(".tar.xz"): with tarfile.open(dataset_filename, "r") as tar_object: - tar_object.extractall(os.path.join(str(Path.home()), "datasets")) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_object, os.path.join(str(Path.home()),"datasets")) def read_metadata(metadata_file: str) -> List: