Skip to content

Commit 88cd3a6

Browse files
mmagicianclaude
andauthored
refactor: rename miden-tx-batch-prover crate to miden-batch (#3035)
* refactor: rename miden-tx-batch-prover crate to miden-batch The crate no longer just proves batches: it executes, proves, and verifies them, and no longer depends on miden-tx (transaction verification moved into miden-protocol). Drop the inaccurate 'tx' and 'prover' qualifiers and name it miden-batch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: add changelog entry for the miden-batch crate rename Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci: update check-features.sh for the miden-batch rename Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Apply suggestion from @mmagician * refactor: use `miden-tx-batch` crate name instead of `miden-batch` * fix: dedupe changelog entry after merge --------- Co-authored-by: Claude (Opus) <noreply@anthropic.com>
1 parent 21022f8 commit 88cd3a6

17 files changed

Lines changed: 29 additions & 28 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## v0.16.0 (TBD)
44

55
### Changes
6+
- [BREAKING] Renamed the `miden-tx-batch-prover` crate to `miden-tx-batch` ([#3035](https://github.com/0xMiden/protocol/pull/3035)).
67
- Added a skeleton batch kernel ([#1122](https://github.com/0xMiden/protocol/issues/1122)) wired through `LocalBatchProver::prove` and attached to `ProvenBatch` as an `ExecutionProof`. It does not yet perform any verification.
78

89
- [BREAKING] Renamed `AccountStorageDelta` to `AccountStoragePatch` ([#3002](https://github.com/0xMiden/protocol/pull/3002)).

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ members = [
88
"crates/miden-standards",
99
"crates/miden-testing",
1010
"crates/miden-tx",
11-
"crates/miden-tx-batch-prover",
11+
"crates/miden-tx-batch",
1212
]
1313
resolver = "3"
1414

@@ -36,13 +36,13 @@ lto = true
3636

3737
[workspace.dependencies]
3838
# Workspace crates
39-
miden-agglayer = { default-features = false, path = "crates/miden-agglayer", version = "0.16" }
40-
miden-block-prover = { default-features = false, path = "crates/miden-block-prover", version = "0.16" }
41-
miden-protocol = { default-features = false, path = "crates/miden-protocol", version = "0.16" }
42-
miden-standards = { default-features = false, path = "crates/miden-standards", version = "0.16" }
43-
miden-testing = { default-features = false, path = "crates/miden-testing", version = "0.16" }
44-
miden-tx = { default-features = false, path = "crates/miden-tx", version = "0.16" }
45-
miden-tx-batch-prover = { default-features = false, path = "crates/miden-tx-batch-prover", version = "0.16" }
39+
miden-agglayer = { default-features = false, path = "crates/miden-agglayer", version = "0.16" }
40+
miden-block-prover = { default-features = false, path = "crates/miden-block-prover", version = "0.16" }
41+
miden-protocol = { default-features = false, path = "crates/miden-protocol", version = "0.16" }
42+
miden-standards = { default-features = false, path = "crates/miden-standards", version = "0.16" }
43+
miden-testing = { default-features = false, path = "crates/miden-testing", version = "0.16" }
44+
miden-tx = { default-features = false, path = "crates/miden-tx", version = "0.16" }
45+
miden-tx-batch = { default-features = false, path = "crates/miden-tx-batch", version = "0.16" }
4646

4747
# Miden dependencies
4848
miden-assembly = { default-features = false, version = "0.23" }

crates/miden-testing/Cargo.toml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ tx_context_debug = []
2222

2323
[dependencies]
2424
# Workspace dependencies
25-
miden-block-prover = { features = ["testing"], workspace = true }
26-
miden-protocol = { features = ["testing"], workspace = true }
27-
miden-standards = { features = ["testing"], workspace = true }
28-
miden-tx = { features = ["testing"], workspace = true }
29-
miden-tx-batch-prover = { features = ["testing"], workspace = true }
25+
miden-block-prover = { features = ["testing"], workspace = true }
26+
miden-protocol = { features = ["testing"], workspace = true }
27+
miden-standards = { features = ["testing"], workspace = true }
28+
miden-tx = { features = ["testing"], workspace = true }
29+
miden-tx-batch = { features = ["testing"], workspace = true }
3030

3131
# Miden dependencies
3232
miden-core-lib = { workspace = true }

crates/miden-testing/src/kernel_tests/batch/batch_verifier.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use anyhow::Context;
22
use assert_matches::assert_matches;
3-
use miden_tx_batch_prover::{BatchExecutor, BatchVerifier, BatchVerifierError, LocalBatchProver};
3+
use miden_tx_batch::{BatchExecutor, BatchVerifier, BatchVerifierError, LocalBatchProver};
44

55
use super::proposed_batch::setup_chain;
66
use super::test_batch_kernel::two_tx_batch;

crates/miden-testing/src/kernel_tests/batch/test_batch_kernel.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use anyhow::Context;
55
use miden_protocol::Word;
66
use miden_protocol::batch::ProposedBatch;
77
use miden_protocol::block::BlockNumber;
8-
use miden_tx_batch_prover::{BatchExecutor, LocalBatchProver};
8+
use miden_tx_batch::{BatchExecutor, LocalBatchProver};
99

1010
use super::proposed_batch::{TestSetup, mock_note, mock_output_note, setup_chain};
1111
use super::proven_tx_builder::MockProvenTxBuilder;

crates/miden-testing/src/mock_chain/chain.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ use miden_protocol::transaction::{
3333
use miden_tx::LocalTransactionProver;
3434
use miden_tx::auth::BasicAuthenticator;
3535
use miden_tx::utils::serde::{ByteReader, ByteWriter, Deserializable, Serializable};
36-
use miden_tx_batch_prover::LocalBatchProver;
36+
use miden_tx_batch::LocalBatchProver;
3737

3838
use super::note::MockChainNote;
3939
use crate::{MockChainBuilder, TransactionContextBuilder};

crates/miden-tx-batch-prover/README.md

Lines changed: 0 additions & 7 deletions
This file was deleted.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
[package]
22
authors.workspace = true
33
categories = ["no-std"]
4-
description = "Miden blockchain transaction batch executor and prover"
4+
description = "Miden blockchain transaction batch executor, prover, and verifier"
55
edition.workspace = true
66
homepage.workspace = true
77
keywords = ["batch", "miden", "prover"]
88
license.workspace = true
9-
name = "miden-tx-batch-prover"
9+
name = "miden-tx-batch"
1010
readme = "README.md"
1111
repository.workspace = true
1212
rust-version.workspace = true

crates/miden-tx-batch/README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# Miden Transaction Batch
2+
3+
This crate contains tools for executing, proving, and verifying Miden transaction batches.
4+
5+
## License
6+
7+
This project is [MIT licensed](../../LICENSE).

0 commit comments

Comments
 (0)